cannon: Update version of go used in cannon stf-diff #12218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12218 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3665 3665
===========================================
- Hits 2756 2748 -8
- Misses 736 745 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Inphi
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cannon examples were switched to go1.22 - update the stf diff check to use a docker image with go 1.22 (cannon itself is still go 1.21 along with the rest of the monorepo but we want to test compatibility with go 1.22).