Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Bump go tests to go1.22 #12214

Merged

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Sep 30, 2024

Description

Bump go test programs up to go1.22.

Metadata

Fixes #12146

@mbaxter mbaxter changed the title cannon: Bump go tests to go1 22 cannon: Bump go tests to go1.22 Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (52d0e60) to head (4a30e44).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12214      +/-   ##
===========================================
- Coverage    75.08%   74.97%   -0.11%     
===========================================
  Files           49       49              
  Lines         3665     3665              
===========================================
- Hits          2752     2748       -4     
- Misses         739      745       +6     
+ Partials       174      172       -2     
Flag Coverage Δ
cannon-go-tests 74.97% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@mbaxter mbaxter requested a review from Inphi September 30, 2024 21:56
@mbaxter mbaxter marked this pull request as ready for review September 30, 2024 21:56
@mbaxter mbaxter requested review from a team as code owners September 30, 2024 21:56
@mbaxter mbaxter added this pull request to the merge queue Sep 30, 2024
Merged via the queue into ethereum-optimism:develop with commit 75b0e66 Sep 30, 2024
61 checks passed
@mbaxter mbaxter deleted the issue-12146/compile-tests-for-go1-22 branch September 30, 2024 22:32
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* cannon: Update cannon go test program versions

* cannon: Allow more steps for multithreaded program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MT-Cannon: Support go1.22
2 participants