Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces in OPCM and OPCMInterop #12188

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Interfaces in OPCM and OPCMInterop #12188

merged 6 commits into from
Sep 28, 2024

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 27, 2024

Use interfaces in the OPCM to reduce source code size.

Replaces #12183 which was accidentally merged into feat/sepolia-deployment.

This should go in after #12182, and it will have conflict in the OPCM semver and semver-lock once it has.

@maurelian maurelian requested a review from a team as a code owner September 27, 2024 21:05
@maurelian maurelian requested review from smartcontracts and removed request for a team September 27, 2024 21:05
Base automatically changed from feat/sepolia-deployment to develop September 27, 2024 21:34
@circleci-checks circleci-checks bot requested review from a team as code owners September 27, 2024 21:34
@mds1 mds1 enabled auto-merge September 28, 2024 00:06
@mds1 mds1 added this pull request to the merge queue Sep 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2024
@mds1 mds1 added this pull request to the merge queue Sep 28, 2024
Merged via the queue into develop with commit 6ba2ac0 Sep 28, 2024
61 checks passed
@mds1 mds1 deleted the opcm/interfaces branch September 28, 2024 00:41
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* Updates to OPCM and OPCMInterop

* Update DeployImpls and OPCM Tests

* remove some unused imports

* Undo mapping type change

* Undo DeployOutput type change

* Semver and snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants