Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devnet tests #12170

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Remove devnet tests #12170

merged 1 commit into from
Sep 27, 2024

Conversation

mslipper
Copy link
Collaborator

The devnet tests aren't providing a lot of value. They use our outdated Python devnet tooling, and only run a tiny subset of our overall test suite. They are also are flaky and slow to run. To prioritize improving the DevX of the monorepo, this PR removes the devnet tests from CCI.

@mslipper mslipper requested a review from a team as a code owner September 27, 2024 05:39
@mslipper mslipper requested a review from geoknee September 27, 2024 05:39
The devnet tests aren't providing a lot of value. They use our outdated Python devnet tooling, and only run a tiny subset of our overall test suite. They are also are flaky and slow to run. To prioritize improving the DevX of the monorepo, this PR removes the devnet tests from CCI.
@mslipper mslipper force-pushed the feat/remove-devnet-tests branch from 9a8bd89 to 4c5f327 Compare September 27, 2024 05:41
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (32a3637) to head (4c5f327).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12170      +/-   ##
===========================================
- Coverage    75.19%   74.97%   -0.22%     
===========================================
  Files           49       49              
  Lines         3656     3656              
===========================================
- Hits          2749     2741       -8     
- Misses         734      743       +9     
+ Partials       173      172       -1     
Flag Coverage Δ
cannon-go-tests 74.97% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit 169f808 Sep 27, 2024
64 checks passed
@mslipper mslipper deleted the feat/remove-devnet-tests branch September 27, 2024 14:51
maurelian pushed a commit that referenced this pull request Sep 27, 2024
The devnet tests aren't providing a lot of value. They use our outdated Python devnet tooling, and only run a tiny subset of our overall test suite. They are also are flaky and slow to run. To prioritize improving the DevX of the monorepo, this PR removes the devnet tests from CCI.
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
The devnet tests aren't providing a lot of value. They use our outdated Python devnet tooling, and only run a tiny subset of our overall test suite. They are also are flaky and slow to run. To prioritize improving the DevX of the monorepo, this PR removes the devnet tests from CCI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants