ci: Add Cannon STF verify recurring job #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inphi
force-pushed
the
inphi/cannon-verify-ci
branch
2 times, most recently
from
f51ef22 to
66d7168
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12165 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3656 3656
===========================================
- Hits 2749 2741 -8
- Misses 734 743 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Inphi
force-pushed
the
inphi/cannon-verify-ci
branch
from
e127562 to
a9ac786
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* ci: Add Cannon STF verify recurring job * setup remote docker * change make dir * fix cwd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a recurring CI job that compares the generated states and execution of cannon against an older cannon release. It's an sanity check, over the existing VM tests, asserting that the Cannon STF isn't altered. This can be more robust than existing tests in the VM as it avoids bugs introduced to the test themselves.
For now, the job asserts that changes to Cannon does not alter the state transition function of the singlethreaded V1 state version (i.e. the version used for the Granite upgrade). In the future, the new job will be extended to verify multithreaded cannon and the upcoming cannon STF changes for holocene.