Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change OPCM salt to include user supplied arg #12152

Merged
merged 8 commits into from
Sep 26, 2024
Merged

feat: Change OPCM salt to include user supplied arg #12152

merged 8 commits into from
Sep 26, 2024

Conversation

blmalone
Copy link
Contributor

No description provided.

@blmalone blmalone marked this pull request as ready for review September 26, 2024 17:59
@blmalone blmalone requested review from a team as code owners September 26, 2024 17:59
@blmalone blmalone requested review from clabby and geoknee September 26, 2024 17:59
@blmalone Graphite App
Copy link
Contributor Author

blmalone commented Sep 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone requested review from mds1 and removed request for geoknee and clabby September 26, 2024 18:00
@blmalone blmalone mentioned this pull request Sep 26, 2024
Merged
mds1
mds1 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blmalone blmalone mentioned this pull request Sep 26, 2024
Merged
@blmalone blmalone requested a review from mds1 September 26, 2024 18:34
@blmalone Graphite App
Copy link
Contributor Author

Merge activity

  • Sep 26, 3:10 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@blmalone blmalone force-pushed the 09-26-feat_change_opcm_salt_to_include_user_supplied_arg branch from 053537f to 27dcc0e Compare September 26, 2024 19:19
mslipper
mslipper reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending comment

@blmalone blmalone mentioned this pull request Sep 26, 2024
Merged
mslipper
mslipper approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blmalone blmalone added this pull request to the merge queue Sep 26, 2024
Merged via the queue into develop with commit 521fab3 Sep 26, 2024
65 checks passed
@blmalone blmalone deleted the 09-26-feat_change_opcm_salt_to_include_user_supplied_arg branch September 26, 2024 21:29
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@blmalone @samlaf
feat: Change OPCM salt to include user supplied arg (ethereum-optimis…
3424657 
…m#12152)

* feat: Change OPCM salt to include user supplied arg

* fix: removing temporary assumption.

* fix: bumped OPContractsManager version.

* fix: snapshots update.

* fix: bump OPContractsManager version.

* fix: snapshots update.

* fix: pre-pr run

* fix: wiring up Create2Salt as SaltMixer for DeployOPChainInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslipper mslipper mslipper approved these changes

@mds1 mds1 Awaiting requested review from mds1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blmalone @mslipper @mds1