cannon: Output information about the state in JSON format from the witness command

[ajsutton]

Description

Will provide all the information about a state that the challenger needs so it doesn't have to depend on the parsing code directly.

Also set the default target for make to cannon - previously it was just building cannon-impl so the bin/cannon command didn't get updated.

[semgrep-app]

Semgrep found 35 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/safe/SafeSigners.sol
  • L23 - Triage
  • L52 - Triage
• packages/contracts-bedrock/src/cannon/MIPS2.sol
  • L598 - Triage
  • L720 - Triage
  • L771 - Triage
• packages/contracts-bedrock/src/L2/interfaces/IOptimismERC20Factory.sol
  • L11 - Triage
• packages/contracts-bedrock/src/L2/interfaces/IL2ToL2CrossDomainMessenger.sol
  • L22 - Triage
  • L26 - Triage
• packages/contracts-bedrock/src/L2/interfaces/ICrossL2Inbox.sol
  • L22 - Triage
  • L26 - Triage
  • L30 - Triage
  • L34 - Triage
  • L38 - Triage
• packages/contracts-bedrock/src/L2/OptimismSuperchainERC20Factory.sol
  • L46 - Triage
• packages/contracts-bedrock/src/L2/OptimismSuperchainERC20.sol
  • L53 - Triage
• packages/contracts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol
  • L82 - Triage
  • L90 - Triage
• packages/contracts-bedrock/src/L1/L1CrossDomainMessenger.sol
  • L64 - Triage
• packages/contracts-bedrock/scripts/periphery/drippie/ManageDrippie.s.sol
  • L113 - Triage
  • L169 - Triage
• packages/contracts-bedrock/scripts/periphery/drippie/DrippieConfig.s.sol
  • L69 - Triage
• packages/contracts-bedrock/scripts/periphery/deploy/PeripheryDeployConfig.s.sol
  • L43 - Triage
• packages/contracts-bedrock/scripts/libraries/Config.sol
  • L68 - Triage
  • L76 - Triage
  • L87 - Triage
  • L94 - Triage
  • L99 - Triage
  • L105 - Triage
  • L115 - Triage
  • L120 - Triage
  • L142 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L97 - Triage
  • L194 - Triage
  • L197 - Triage
  • L200 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 44 sol-style-input-arg-fmt findings:

• packages/contracts-bedrock/src/universal/StorageSetter.sol
  • L29 - Triage
• packages/contracts-bedrock/src/safe/SafeSigners.sol
  • L17-18 - Triage
  • L45-46 - Triage
• packages/contracts-bedrock/src/safe/LivenessGuard.sol
  • L68-69 - Triage
• packages/contracts-bedrock/src/libraries/Encoding.sol
  • L147-148 - Triage
• packages/contracts-bedrock/src/cannon/libraries/MIPSState.sol
  • L14 - Triage
• packages/contracts-bedrock/src/L1/interfaces/IDelayedVetoable.sol
  • L17 - Triage
  • L22 - Triage
• packages/contracts-bedrock/src/L1/interfaces/IDataAvailabilityChallenge.sol
  • L47 - Triage
  • L51-52 - Triage
  • L58-59 - Triage
  • L75-76 - Triage
  • L86 - Triage
  • L87 - Triage
• packages/contracts-bedrock/src/L1/OPContractsManagerInterop.sol
  • L22-23 - Triage
• packages/contracts-bedrock/src/L1/OPContractsManager.sol
  • L434-435 - Triage
• packages/contracts-bedrock/src/L1/DelayedVetoable.sol
  • L116 - Triage
  • L179 - Triage
• packages/contracts-bedrock/src/L1/DataAvailabilityChallenge.sol
  • L215 - Triage
  • L222 - Triage
  • L231-232 - Triage
  • L246-247 - Triage
  • L272 - Triage
  • L281 - Triage
  • L300 - Triage
  • L341-342 - Triage
  • L391 - Triage
  • L430 - Triage
  • 1 more - Triage
• packages/contracts-bedrock/scripts/libraries/ForgeArtifacts.sol
  • L270-271 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L269 - Triage
  • L273 - Triage
  • L277 - Triage
  • L281 - Triage
  • L286-287 - Triage
• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L285-289 - Triage
• packages/contracts-bedrock/scripts/DeploySuperchain.s.sol
  • L167 - Triage
• packages/contracts-bedrock/scripts/DeployOPChain.s.sol
  • L167 - Triage
• packages/contracts-bedrock/scripts/DeployImplementations.s.sol
  • L67 - Triage
  • L86 - Triage
  • L93 - Triage
  • L100 - Triage
  • L182 - Triage
• packages/contracts-bedrock/scripts/DeployAuthSystem.s.sol
  • L52 - Triage

Inputs to functions must be prepended with an underscore (_)

_{Ignore this finding from sol-style-input-arg-fmt.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (4680790) to head (d14c9b2).
Report is 14 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12137      +/-   ##
===========================================
- Coverage    75.16%   74.94%   -0.22%     
===========================================
  Files           49       49              
  Lines         3652     3652              
===========================================
- Hits          2745     2737       -8     
- Misses         734      743       +9     
+ Partials       173      172       -1     

Flag	Coverage Δ
cannon-go-tests	74.94% <ø> (-0.22%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cannon/multicannon/witness.go	0.00% <ø> (ø)

... and 1 file with indirect coverage changes

[Inphi]

This is OK. Is the printed state data printed to stdout needed by the op-challenger? If so, we should write to a file instead.
It's not too late to break the cannon CLI.

[Inphi]

This is OK. Is the printed state data printed to stdout needed by the op-challenger? If so, we should write to a file instead. It's not too late to break the cannon CLI.

Nvmind this. The witness subcommand is simple enough that I'm not too concerned with a random logger breaking stdout.