test(deploy): Deploy a distinct ProxyAdmin for Superchain contracts #12130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
8adedf0 to
3f648c1
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
a31d1b1 to
8e252e9
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
3f648c1 to
0e8f1ff
Compare
|
Looks like this one has some test failures to resolve |
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
8e252e9 to
07688b6
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
2 times, most recently
from
ae5848f to
a49afa9
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
4f6dc93 to
7a46da7
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
88947e7 to
50576e3
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
7a46da7 to
f8f074b
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
50576e3 to
e892193
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
f8f074b to
71a4ea3
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
e892193 to
a2474c4
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
c05fc51 to
ba58e61
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
a2474c4 to
aaa3df4
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
ba58e61 to
88032de
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
8befea8 to
fcc7396
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
fcc7396 to
cac52a4
Compare
Merge activity
|
The DA challenge contract needs a proxy admin too
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
cac52a4 to
86c36b2
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
maurelian
commented
Sep 30, 2024
maurelian
commented
Sep 30, 2024
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
aac2306 to
f84ce54
Compare
maurelian
force-pushed
the
opcm/in-tests-4
branch
from
f84ce54 to
936be21
Compare
mds1
reviewed
Sep 30, 2024
packages/contracts-bedrock/scripts/deploy/DeployOwnership.s.sol
Outdated
Show resolved
Hide resolved
mds1
approved these changes
Sep 30, 2024
Co-authored-by: Matt Solomon <[email protected]>
This was referenced Oct 1, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…thereum-optimism#12130) * test(deploy): Deploy a distinct ProxyAdmin for Superchain contracts * fix: only set address manager for OP Chain's ProxyAdmin * fix: typo * test: fix create2 collision between ProxyAdmins * fix: lint * fix: move setupOpChainAdmin() before setupOpAltDA The DA challenge contract needs a proxy admin too * feat: use create2AndSave for ProxyAdmin * fix: Do not double save the superchain ProxyAdmin * Fix whitespace Co-authored-by: Matt Solomon <[email protected]> --------- Co-authored-by: Matt Solomon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(deploy): Deploy a distinct ProxyAdmin for Superchain contracts
fix: only set address manager for OP Chain's ProxyAdmin