-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-supervisor: cleanup cross-L2 safety types #12098
Conversation
Why not change the RPC labels for explicit local/cross, so that way they're consistent and fully qualified? |
757dd3e
to
a8f3c98
Compare
a8f3c98
to
d62f49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
I've approved, but some test expectations aren't matching:
|
* op-supervisor: cleanup cross-L2 safety types * op-node: fix interop test
Description
This:
cross-finalized
/local-finalized
difference. Finality depends on cross-safe limited to a view of irreversible L1 blocks. Taking a combination of local-finalized chains is not the same. And having two levels of finality is confusing.