Use DA /put path from spec #12081
Merged
Use DA /put path from spec #12081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the currently used `/put/` path to ease the migration. See ethereum-optimism#11499.
The spec mandates using `/put` and not `/put/`, so that is what we should do. Warning: This will break DA solutions that only accept `/put/` at the moment. It is recommended that DA solutions support both paths for a while, so that updating OP-stack can happen independently of the exact DA implementation version. Closes ethereum-optimism#11499.
karlb
force-pushed
the
karlb/da-put-path
branch
from
f63c9bb to
93c82cd
Compare
tynes
approved these changes
Sep 27, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 27, 2024
a9c7f34
58 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* Accept /put path as described in spec In addition to the currently used `/put/` path to ease the migration. See ethereum-optimism#11499. * alt-DA: write to /put path as described in spec The spec mandates using `/put` and not `/put/`, so that is what we should do. Warning: This will break DA solutions that only accept `/put/` at the moment. It is recommended that DA solutions support both paths for a while, so that updating OP-stack can happen independently of the exact DA implementation version. Closes ethereum-optimism#11499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OP alt-DA spec mandates using
/putand not/put/, so that is what we should do. To ease the migration, the DA server supports both paths for now.Warning: The changed path in the DA client will break DA solutions that only accept
/put/at the moment. It is recommended that DA solutions support both paths for a while, so that updating OP-stack can happen independently of the exact DA implementation version.If we want to give other DAs a head start on supporting both paths, we can only merge the first commit now and delay the second commit (but should communicate the upcoming change).
Tests
The existing DA tests should cover this just as well as the previous version. I can modify the tests to run against both paths if desired, but I'm not sure if that isn't too much considering that having both paths active is a temporary measure.
Metadata