Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(L2ToL2CrossDomainMessenger): add successfulMessages and messageNonce to IL2ToL2CrossDomainMessenger #12068

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

tremarkley
Copy link
Contributor

No description provided.

@tremarkley tremarkley requested a review from a team as a code owner September 23, 2024 20:13
@tremarkley tremarkley requested a review from clabby September 23, 2024 20:13
@tremarkley tremarkley changed the title feat(L2ToL2CrossDomainMessenger): add successfulMessages and messageNonce to interface feat(L2ToL2CrossDomainMessenger): add successfulMessages and messageNonce to IL2ToL2CrossDomainMessenger Sep 23, 2024
Copy link
Contributor

semgrep-app bot commented Sep 23, 2024

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/src/L1/OPStackManager.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 13 sol-style-notice-over-dev-natspec findings:

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 10 golang_fmt_errorf_no_params findings:

  • op-supervisor/supervisor/backend/db/safety_checkers_test.go
  • op-supervisor/supervisor/backend/db/db_test.go
  • op-chain-ops/deployer/state/intent.go
  • op-chain-ops/deployer/pipeline/superchain.go
  • op-chain-ops/deployer/pipeline/opchain.go
  • op-chain-ops/deployer/pipeline/l2genesis.go
  • op-chain-ops/deployer/pipeline/implementations.go
  • op-chain-ops/deployer/inspect/rollup.go
  • op-chain-ops/deployer/inspect/flags.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Semgrep found 3 math-random-used findings:

  • cannon/mipsevm/singlethreaded/testutil/state.go
  • cannon/mipsevm/multithreaded/testutil/thread.go
  • cannon/mipsevm/multithreaded/testutil/mutators.go

Do not use math/rand. Use crypto/rand instead.

Ignore this finding from math-random-used.

@tremarkley tremarkley requested a review from tynes September 23, 2024 20:18
Copy link
Collaborator

@skeletor-spaceman skeletor-spaceman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! this Interface needs some love <3 thanks for the PR

@tremarkley tremarkley added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit 9a12768 Sep 23, 2024
63 checks passed
@tremarkley tremarkley deleted the harry/IL2ToL2CrossDomainMessenger_update branch September 23, 2024 21:28
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…once to IL2ToL2CrossDomainMessenger (ethereum-optimism#12068)

* feat(L2ToL2CrossDomainMessenger): add successfulMessages and messageNonce to interface

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants