show block number when "L2 safe head ahead of L2 unsafe head" happens #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
fix_log_calculateL2BlockRangeToStore
branch
from
2b5c0a8 to
403ff9f
Compare
zhiqiangxu
force-pushed
the
fix_log_calculateL2BlockRangeToStore
branch
from
403ff9f to
cb7af27
Compare
axelKingsley
approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12030 +/- ##
===========================================
- Coverage 79.10% 78.87% -0.24%
===========================================
Files 41 41
Lines 3437 3437
===========================================
- Hits 2719 2711 -8
- Misses 548 557 +9
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I see an action test failed, I've rerun the suite in case it's a flakey test. |
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 20, 2024
bd50ac6
61 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very helpful when analyzing reorgs.
Previously submitted here, but was closed because stale.