GasPriceOracle.sol: small fix #11840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you could rebase this and get it to pass the |
|
@tynes Hi I rebased it, but it's hard to find what make the contracts-bedrock-checks fail, I guess maybe I change the comment and the file hash is mismatching with some config? And tips for this? |
|
@tynes Hi Tynes, I think it's good to pass the contracts-bedrock-checks now, the version and hash has been changed to the right. |
|
Hi, sorry for the delay here, can you rebase this PR? thank you! |
Sure, done : ) |
smartcontracts
approved these changes
Oct 23, 2024
|
Thanks! |
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 23, 2024
0ea0441
47 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* small fix * Change version and hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
small fixed on the comment.