Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interop): L2ToL2CDM SentMessage event, Relay Entrypoint, Better Event Topics #11592

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented Aug 23, 2024

  1. Improve DevX by using an explicit SentMessage event.
  2. Leverage contracts-bedrock: improve CrossL2Inbox devex #11322 to provide a public relay entrypoint to consume that event when relaying instead of CrossL2Inbox directly executing relayMessage via the emitted LOG0 event

Include indexed source,nonce as topics in the sent/relay events for easy on-chain indexing & searching

Aside

  • Rename Hashing#hashL2toL2CrossDomainMessengerRelayMessage to Hashing#hashL2toL2CrossDomainMessage

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hamdiallam and the rest of your teammates on Graphite Graphite

@hamdiallam hamdiallam changed the title feat(interop): L2ToL2CDM DevX Improvement prototype feat(interop): L2ToL2CDM DevX Improvement Prototype Aug 23, 2024
@tynes
Copy link
Contributor

tynes commented Sep 13, 2024

Wondering the status on this, if its something that having merged before the first devnet would be ideal

@hamdiallam
Copy link
Contributor Author

Wondering the status on this, if its something that having merged before the first devnet would be ideal

@skeletor-spaceman said they'd take over the PR+spec changes for these changes.

Do y'all want us to do this?

@skeletor-spaceman
Copy link
Collaborator

@tynes we have this as a mid-priority on our tasks. it will get done before devnet :)
@hamdiallam that'd be awesome, we don't want to give you guys more work to do tho, but if you think it's ok we'll happily review the changes on the other 2 repos as well :) -- just let me know so I can un-assign that task internally

@hamdiallam
Copy link
Contributor Author

@tynes we have this as a mid-priority on our tasks. it will get done before devnet :)

@hamdiallam that'd be awesome, we don't want to give you guys more work to do tho, but if you think it's ok we'll happily review the changes on the other 2 repos as well :) -- just let me know so I can un-assign that task internally

Was OOO this week but will sync with the team next Monday and let you know!

@hamdiallam hamdiallam changed the title feat(interop): L2ToL2CDM DevX Improvement Prototype feat(interop): L2ToL2CDM public relay entrypoint Sep 25, 2024
@hamdiallam hamdiallam changed the title feat(interop): L2ToL2CDM public relay entrypoint feat(interop): L2ToL2CDM SentMessage event, Relay Entrypoint, Better Event Topics Sep 25, 2024
@hamdiallam hamdiallam marked this pull request as ready for review September 25, 2024 01:47
@hamdiallam hamdiallam requested a review from a team as a code owner September 25, 2024 01:47
Copy link
Contributor

semgrep-app bot commented Sep 25, 2024

Semgrep found 2 err-todo findings:

TODO in error handling code

Ignore this finding from err-todo.

Copy link
Collaborator

@skeletor-spaceman skeletor-spaceman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested some minor changes and added an interesting question :)

@hamdiallam hamdiallam force-pushed the l2cdm.devx branch 2 times, most recently from 3e51c35 to 1e2d293 Compare September 26, 2024 06:19
@ethereum-optimism ethereum-optimism deleted a comment from semgrep-app bot Sep 26, 2024
Copy link
Contributor

@0xDiscotech 0xDiscotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! I focused on the tests, left few small comments and questions, and also a testFuzz_relayMessage_eventPayloadNotSent_reverts test is missing on the CDM unit tests.

@skeletor-spaceman skeletor-spaceman added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit a96b228 Sep 27, 2024
65 checks passed
@skeletor-spaceman skeletor-spaceman deleted the l2cdm.devx branch September 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants