indexer: remove bindings #10223
indexer: remove bindings #10223
Conversation
WalkthroughWalkthroughThe recent updates involve restructuring import paths in various test and contract processor files within the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (18)
Files not summarized due to errors (5)
Files skipped from review as they are similar to previous changes (13)
Additional comments not posted (27)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
need to fix ci |
|
LGTM |
Removes the dependency on the `op-bindings/bindings` package. This is to improve devex in the monorepo and reduce CI time as maintaining the bindings autogenerated in each PR just doesn't scale. Now each service is responsible for their own bindings. In the future, we can work towards releases of the bindings when contracts are released. Follows: - #10213 - #10218 - #10221
tynes
force-pushed
the
feat/indexer-bindings
branch
from
a1029c2 to
a40d1c7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (11)
indexer/bindings/crossdomainmessenger.go (4)
1-2: Ensure generated code comments are accurate.The file header comments state that this is a generated file and should not be edited manually. Ensure that the generation process is documented and that any manual changes are avoided or properly managed through the generation scripts.
37-38: Consider removing deprecated code.The variable
CrossDomainMessengerABIis marked as deprecated. If it is no longer used in the project, consider removing it to clean up the codebase.
99-106: Ensure error handling is robust.In the constructor function
NewCrossDomainMessenger, ensure that the error returned is handled or logged appropriately in the calling code. This is crucial for debugging deployment issues.
678-697: Review transaction methods for correct parameters and error handling.In transaction methods like
RelayMessage, ensure that the parameters passed and the transaction options are correctly handled. Also, check that errors from the transaction are handled or propagated appropriately.indexer/bindings/l2outputoracle.go (1)
44-50: Deprecation ofL2OutputOracleABIandL2OutputOracleBinshould be clearly documented.Consider adding detailed comments explaining why these variables are deprecated and what should be used instead. This will help developers understand the changes and transition smoothly.
indexer/bindings/l2crossdomainmessenger.go (2)
1-3: Ensure generated code is not manually edited to maintain integrity.
38-43: Consider removing deprecated variables if they are no longer used in the codebase to clean up the code.indexer/bindings/l1crossdomainmessenger.go (4)
38-38: Deprecation notice should be more prominent.Consider using a more noticeable method, such as logging a warning when deprecated variables are accessed, to ensure that developers are aware of the deprecation when using these variables.
159-164: Potential improvement in error handling.Consider adding more specific error messages related to ABI parsing failures to aid in debugging issues related to contract interactions.
866-885: Optimize gas usage in transactional functions.Review the function to ensure it's optimized for gas usage, particularly since it involves multiple contract interactions which can be costly.
1232-1237: Document the event structure clearly.Add detailed comments describing each field in the event structure to improve code readability and maintainability, especially for complex structures.
|
@hamdiallam this is ready for review now |
Description
Removes the dependency on the
op-bindings/bindingspackage.This is to improve devex in the monorepo and reduce CI time
as maintaining the bindings autogenerated in each PR just
doesn't scale. Now each service is responsible for their own
bindings. In the future, we can work towards releases of
the bindings when contracts are released.
Follows:
op-bindings#10221