-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: fix ecotone upgrade test #10092
Conversation
Previously the upgrade transactions test made an assertion against the bytecode that is in the bindings. This needs to be modified because the upgrade txs cannot ever change as they are part of consensus. Any modification to the bindings means that the assertion will fail. We should test against the expected value directly instead of going through the binding that has no guarantee to be on a particular version and will change over time.
WalkthroughThe recent update in the codebase enhances transaction tests by replacing hardcoded binding references with customizable variables. This change offers a more dynamic approach to bytecode comparison, improving the testing framework's flexibility and maintainability. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* op-node: fix ecotone upgrade test Previously the upgrade transactions test made an assertion against the bytecode that is in the bindings. This needs to be modified because the upgrade txs cannot ever change as they are part of consensus. Any modification to the bindings means that the assertion will fail. We should test against the expected value directly instead of going through the binding that has no guarantee to be on a particular version and will change over time. * op-node: fix test
Description
Previously the upgrade transactions test made an assertion against
the bytecode that is in the bindings. This needs to be modified
because the upgrade txs cannot ever change as they are part of
consensus. Any modification to the bindings means that the assertion
will fail. We should test against the expected value directly
instead of going through the binding that has no guarantee
to be on a particular version and will change over time.
Summary by CodeRabbit