golint

ethereum-optimism · Oct 5, 2023 · 37ee20f · 37ee20f
1 parent 630c53f
commit 37ee20f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/cannon/mipsevm/memory.go b/cannon/mipsevm/memory.go
@@ -232,9 +232,13 @@ func (m *Memory) AllocPage(pageIndex uint32) *CachedPage {
 func (m *Memory) Serialize(out io.Writer) error {
 	for k, p := range m.pages {
 		// Write the page index as a big endian uint32
-		binary.Write(out, binary.BigEndian, k)
+		if err := binary.Write(out, binary.BigEndian, k); err != nil {
+			return err
+		}
 		// Write the length of the page data as a big endian uint32
-		binary.Write(out, binary.BigEndian, uint32(len(p.Data)))
+		if err := binary.Write(out, binary.BigEndian, uint32(len(p.Data))); err != nil {
+			return err
+		}
 		// Write the page data
 		n, err := out.Write(p.Data[:])
 		if err != nil {

diff --git a/op-challenger/game/fault/trace/cannon/cannon_state.go b/op-challenger/game/fault/trace/cannon/cannon_state.go
@@ -14,7 +14,7 @@ func parseState(path string) (*mipsevm.State, error) {
 	}
 	defer file.Close()
 	var state mipsevm.State
-	state.Deserialize(file)
+	err = state.Deserialize(file)
 	if err != nil {
 		return nil, fmt.Errorf("invalid mipsevm state (%v): %w", path, err)
 	}

diff --git a/op-challenger/game/fault/trace/cannon/cannon_state_test.go b/op-challenger/game/fault/trace/cannon/cannon_state_test.go
@@ -25,7 +25,8 @@ func TestLoadState(t *testing.T) {
 		require.NoError(t, err)
 
 		expected := &mipsevm.State{}
-		expected.Deserialize(bytes.NewReader(testState))
+		err = expected.Deserialize(bytes.NewReader(testState))
+		require.NoError(t, err)
 		require.Equal(t, expected, state)
 	})
 
@@ -44,7 +45,8 @@ func TestLoadState(t *testing.T) {
 		require.NoError(t, err)
 
 		expected := &mipsevm.State{}
-		expected.Deserialize(bytes.NewReader(testState))
+		err = expected.Deserialize(bytes.NewReader(testState))
+		require.NoError(t, err)
 		require.Equal(t, expected, state)
 	})
 }