Skip to content

Commit

Permalink
op-service: fix error handling in LoadOPStackChainConfigFromChainID
Browse files Browse the repository at this point in the history
The error should be returned if it is NOT nil. Otherwise, nil will
returned in both cases.
  • Loading branch information
karlb committed Feb 18, 2025
1 parent 42acc17 commit 333bfd5
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions op-service/superutil/chain_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,5 @@ func LoadOPStackChainConfigFromChainID(chainID uint64) (*params.ChainConfig, err
if err != nil {
return nil, fmt.Errorf("unable to retrieve chain %d config: %w", chainID, err)
}
executionConfig, err := params.LoadOPStackChainConfig(chainCfg)
if err == nil {
return executionConfig, err
}
return executionConfig, nil
return params.LoadOPStackChainConfig(chainCfg)
}

0 comments on commit 333bfd5

Please sign in to comment.