-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): Improve kurtosis workflow #57
Conversation
c00be49
to
da93e7b
Compare
c585feb
to
f780ae5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! some comments:
i) since it takes such a long time to build op-reth, it would be best if we can run all the local setups every time like it was before, i.e.
- op-reth<>op-node<>op-geth(sequencer)
- op-reth(sequencer)<>op-node<>op-geth
- op-reth<>op-node
- op-node<>op-geth
it would make more sense if the drop down menu just has the options local or remote rather, and in the case of local, that it continue to provide the specification of fork and branch.
ii) the possibility to collapse logs for a certain component is great. can we always dump logs, i.e. also on positive outcome? that we we can see in the output what kind of transactions and blocks are being built and gossiped. this is possibly out of scope of this pr.
1590923
to
92a061b
Compare
ef0ba76
to
a268ef8
Compare
a268ef8
to
930fe34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c93a1d4
to
1777099
Compare
@emhane updated: ![]() |
In this PR
The biggest change is the ability to filter the kurtosis setups by any glob - users can type in
local
,remote
,no_op_geth
etc and the job will only run the matching setups. Besides this a lot of improvements were introduced:local
/remote
kurtosis configurations in a matrix jobnotify-on-error
job that never worked since it's not connected to Slacklatest
as the default tag forop-node
instead ofdevelop
op-reth
image was specified asop-reth:latest
which does not exist)https://github.com/org/repo.git
- let them just typeorg/repo
This is an example run where the block creation failed. Check the dump logs job - it has the kurtosis logs arranged into collapsible UI groups for ease of use.
This is an example of a job with no filter
This is an example of a job with
no_op_geth
filterThis is an example of a job with filter that does not match anything. spoiler alert: it fails
Fixes #53