op-batcher: exit building loop early if there's not enough DA capacity #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
da-filter-optimization
branch
from
ef76308 to
a4e4a3e
Compare
roberto-bayardo
changed the title
sebastianst
reviewed
Dec 2, 2024
…ction in the block
roberto-bayardo
force-pushed
the
da-filter-optimization
branch
from
a4e4a3e to
5c364ef
Compare
sebastianst
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor optimization:
If there is not enough DA capacity remaining in the block being built to support a minimum sized transaction, then block building can exit early.
Context
We see the DA filtering log line being triggered frequently due to this situation in Base mainnet logs.