-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FMA for operator fee #186
base: main
Are you sure you want to change the base?
Conversation
- [Spec](https://github.com/ethereum-optimism/specs/pull/382) | ||
|
||
## Failure Modes and Recovery Paths | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Database growth increase results in need for 4444 faster or other history expiry solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the other potential history expiry solutions? Just state pruning?
Also, the operator fee won't result in significant database growth on it's own right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a question for you to answer :)
Basically whatever the extra data to the L1 attributes txs is, that is stored to the db every 2s for OPM and Base, every 1s for Unichain/Ink/Soneium, so that adds up to be a lot over time. Its just a consideration and not a blocker. Eventually we need to use a diff based L1 attributes tx to not repeat data being sent over and over again
Any other failure modes that come to mind @tynes? Are there other external parties beyond wallets that may fail to update their fee estimation logic that we should be aware of? |
we have some considerations for generic hardforks here: could be useful to look at this too |
Description
This PR introduces the FMA for the operator fee feature, set to be included in Isthmus.
Additional context