This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
attempt to fix disconnect crash #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the socket pointers to shared ptrs which will should not be released if there is a call to async_write during a delete. This is a fix for ethereum-mining#929 ethereum-mining#892 ethereum-mining#890 and ethereum-mining#887
jean-m-cyr
approved these changes
Mar 27, 2018
|
Great!! |
|
@chfast is this already included in the latest appveyor artifact? |
|
Yes. Include in the last RC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the socket pointers to shared ptrs which will should
not be released if there is a call to async_write during a delete.
This is a fix for #929 #892 #890 and #887