Cleanup PoolClient

libethcore/Farm.h

@@ -57,7 +57,6 @@ class Farm: public FarmFace
 	};
 
 	Farm(boost::asio::io_service & io_service): 
-		m_io_service(io_service),
 		m_io_strand(io_service),
 		m_hashrateTimer(io_service)
 	{
@@ -441,7 +440,6 @@ class Farm: public FarmFace
 
 	// std::thread m_serviceThread;  ///< The IO service thread.
 
-	boost::asio::io_service & m_io_service;							// The IO service reference passed in the constructor
 	boost::asio::io_service::strand m_io_strand;
 	boost::asio::deadline_timer m_hashrateTimer;
 	std::vector<WorkingProgress> m_lastProgresses;

libpoolprotocols/PoolClient.h

@@ -16,6 +16,9 @@ namespace dev
 		class PoolClient
 		{
 		public:
+			virtual ~PoolClient() noexcept = default;
+
+
 			void setConnection(URI &conn)
 			{
 				m_conn = conn;

libpoolprotocols/stratum/EthStratumClient.h

@@ -27,19 +27,19 @@ class EthStratumClient : public PoolClient
 	EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string const & email, bool const & submitHashrate);
 	~EthStratumClient();
 
-	void connect();
-	void disconnect();
+	void connect() override;
+	void disconnect() override;
 
 	// Connected and Connection Statuses
 	bool isConnected() override { return m_connected.load(std::memory_order_relaxed) && !isPendingState(); }
 	bool isPendingState() override { return (m_connecting.load(std::memory_order_relaxed) || m_disconnecting.load(std::memory_order_relaxed));}
 
 	bool isSubscribed() { return m_subscribed.load(std::memory_order_relaxed); }
 	bool isAuthorized() { return m_authorized.load(std::memory_order_relaxed); }
-	string ActiveEndPoint() { return " [" + toString(m_endpoint) + "]"; };
+	string ActiveEndPoint() override { return " [" + toString(m_endpoint) + "]"; };
 
-	void submitHashrate(string const & rate);
-	void submitSolution(Solution solution);
+	void submitHashrate(string const & rate) override;
+	void submitSolution(Solution solution) override;
 
 	h256 currentHeaderHash() { return m_current.header; }
 	bool current() { return static_cast<bool>(m_current); }