Kick on deauth #817
Merged
Kick on deauth #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
global vars? |
|
johnyma22, I didn't mean to put any in, which ones do you see? |
|
I guess I could take out some of these variables, I didn't look too closely at it. One moment. |
|
Try that on for size! |
|
Looks better, can't avoid padIds? |
This should do the trick for issue 815. Please review and merge if it works. Try again: Fewer variables.
|
Hm, I didn't look at that too closely either. Turns out getReadOnly or whatever isn't terribly useful. Here we go again! |
|
Um, this may have broken everything. johnyma22, did you try running it and editing a pad? |
|
yep, testing on a clean pull now. |
|
I fixed it, my latest has the fix, let me do a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should do the trick for issue 815. Please review and merge if
it works.