-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix document not scrolling in iOS (all browsers) #5599
Conversation
Thank you! |
The issue doesn't appear to be present in the timeslider on any browser. |
I imagine this will break some plugins.. Afaik some plugins reference #editorcontainer > #editorcontainerbox and wrapping this will cause that selector to no longer function. I am not 100% certain but I imagine this PR is going to cause issues so I wont merge until I'm sure. |
I'm not sure if Dependabot also rebases non Dependabot pull requests 😅 |
Why would it need to rebase this? It's only one commit. |
7e49f43
to
ce5cdae
Compare
There is a good explanation here about rebasing. In essence it puts your commit on top of the git commits. We want to test your commits against the latest develop branch so we can make sure that your changes work with the latest version and not with the version that you forked from 1/2 year ago. I'll let the pipelines run and after that I'll take a look if any plugin might be broken with this change. @JohnMcLear Could you point me in a direction. I'm not quite up to date which plugins there are and which might be broken after this. |
ce5cdae
to
cc001e7
Compare
This patches a bug where users cannot scroll a document on iOS, because iOS does not allow iframes to be scrolled. See https://davidwalsh.name/scroll-iframes-ios for details.
cc001e7
to
ac3bbc2
Compare
Thisbadds an element as a parent before the editorcontainer. Any CSS reference to foo > bar > editorcontainer could be broken by this afaik but this I'm only 50% confident. |
This reverts commit 2301fdd.
This patches a bug where users cannot scroll a document on iOS, because iOS does not allow iframes to be scrolled.
See https://davidwalsh.name/scroll-iframes-ios for details.
This is purely a cosmetic change, so a frontend test is not applicable for it.
Tested on iOS 12