-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 2 columns: Size and Revisions and made all column headers sortable #20
Conversation
Look at files changed to see what actually got changed. I think what you think you have done and what you actually have done are not the same. |
Good day John, However, the new code is working very well and adds 2 more columns and sorting to all columns. Please feel free to merge and see all changed and added files here: Pasted from the updated README.md: New features on Dec. 07, 2020 New columns: Pad size, No. of revisions Currently up to 35,000 pads can be handled. On re-sorting padManager.listAllPads() ist called again. This should only happen a single time on startup. |
Thank you for your work. Before this can be merged, a lot needs to change:
Before you spend any more time on this, please describe the approach you are taking (or would like to take) so that we can discuss. (Probably comment in #18, or open a new issue.) There are many existing JavaScript libraries that can be used here; if there is one that is a good fit for this I would like to take advantage of it. I'm going to close this PR because I don't expect it to be ready for review any time soon. When you have addressed all of the above issues and believe it is ready, please open a new PR. |
I added 2 columns: Size and Revisions to adminpads2 and made all column headers sortable.
For this pull request I created a new fork of adminpads2: https://github.com/HarryBleckert/ep_adminpads2
Changed files:
pads.js
pads.html
index.js
locales/en.json
Added files:
locales/de.json
Added folders
static/js/admin/js-cookie
static/js/admin/img