Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to solc 0.4.24 #12

Merged
merged 6 commits into from
Jun 22, 2018
Merged

Update to solc 0.4.24 #12

merged 6 commits into from
Jun 22, 2018

Conversation

tbocek
Copy link
Contributor

@tbocek tbocek commented Jun 21, 2018

Also removed manual compiling and using binaries from https://github.com/ethereum/solidity/releases.

@mkalinin
Copy link
Contributor

What is the purpose of removing some files from scripts?
Could you, also, update README.md?

@mkalinin
Copy link
Contributor

Fixes #10

@tbocek
Copy link
Contributor Author

tbocek commented Jun 21, 2018

The files in scripts were used to compile solc for windows and linux. Since the binaries are now downloaded from https://solidity.readthedocs.io/en/latest/installing-solidity.html#binary-packages within the gradle build process, they are not needed anymore. So I removed them.

The version numbers are updated in README.md in this pull request.

@mkalinin
Copy link
Contributor

The version numbers are updated in README.md in this pull request.

Ah, yes. Sorry.
I don't see any drawbacks in keeping old scripts. It is good to have an alternative way of getting those binaries. I am about to merge when you bring scripts back.

@tbocek
Copy link
Contributor Author

tbocek commented Jun 22, 2018

Alright, now keeping the old scripts and explaining in the instructions why this directory is there.

@mkalinin
Copy link
Contributor

Thanks for your awesome work!

@mkalinin mkalinin merged commit a7f2ba3 into ether-camp:master Jun 22, 2018
@mkalinin
Copy link
Contributor

@zilm13
Copy link

zilm13 commented Jul 5, 2018

Both 0.4.23 and 0.4.24 not working for me on Mac, while 0.4.19 is ok
When compiling something, stdout and stderr both are empty, while exit code is 132

@tbocek
Copy link
Contributor Author

tbocek commented Jul 6, 2018

I just noticed the same thing. A friend of mine that has a Mac and did not compile solc on his machine, reported that its missing the libz3 library. It seems that the binaries on Mac are not statically linked. I don't think that solidity will provide a Mac binary soon: ethereum/solidity#3168. Thus, keeping up with new releases will be a pain for those who don't have a Mac.

@tbocek tbocek mentioned this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants