Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement guild bank deposit logic #384

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Implement guild bank deposit logic #384

merged 3 commits into from
Oct 23, 2024

Conversation

ethanmoffat
Copy link
Owner

No description provided.

@ethanmoffat ethanmoffat added this to the Version 1 milestone Oct 23, 2024
sorokya
sorokya approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sorokya sorokya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

sorokya
sorokya suggested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sorokya sorokya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add gold name after value in deposit dialog

EndlessClient/Subscribers/GuildEventSubscriber.cs Outdated Show resolved Hide resolved
@ethanmoffat ethanmoffat merged commit f380b5d into feature/guilds Oct 23, 2024
3 checks passed
@ethanmoffat ethanmoffat deleted the guild_bank branch October 23, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorokya sorokya sorokya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanmoffat @sorokya