Implement Player Freeze (Walk Open, Walk Close) #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmoffat
requested changes
Jul 28, 2024
Freeze will be handled by input validators at controller level
- Use property on Character class to indicate freeze. - Move all freeze validation logic to validator layer. - Restructure some conditions to properly handle freeze for inputs. - Add SFX notification on WALK_OPEN/WALK_CLOSE packets. Rename previously unknown SFX
Vanilla client does not enforce this. Also enable showing first time player message if the login code is not 'no', which handles unexpected values of the login code more closely to the vanilla client.
ethanmoffat
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalkValidationActions and AttackValidationActions currently exists. FaceValidationActions, EmoteValidationActions, and SitValidationActions could exist, but wasn't sure if it'd be appropriate to create for a single feature like this.
Closes #350