Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send WALK_SPEC for ghost walking #359

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

sorokya
Copy link
Contributor

@sorokya sorokya commented Jun 6, 2024

Closes #349

This is disgusting and I'm ashamed. Please tell me how to do it better lmao

@ethanmoffat
Copy link
Owner

Closes #349

This is disgusting and I'm ashamed. Please tell me how to do it better lmao

Honestly probably not much different than I would have done it. You're kinda stuck doing it this way because CharacterAnimator is spaghetti. My only suggestion would be to add explicit methods for WalkGhost but that doesn't really make a ton of sense.

@sorokya sorokya requested a review from ethanmoffat June 15, 2024 13:44
Copy link
Owner

@ethanmoffat ethanmoffat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to add the ghosted: false parameter to the call in EOBot, so the solution keeps building

EndlessClient/Controllers/ArrowKeyController.cs Outdated Show resolved Hide resolved
@ethanmoffat ethanmoffat merged commit 4c289a3 into ethanmoffat:master Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send WALK_SPEC when ghosting players
2 participants