Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SFX/MFX #192

Merged
merged 23 commits into from
May 24, 2022
Merged

Implement SFX/MFX #192

merged 23 commits into from
May 24, 2022

Conversation

ethanmoffat
Copy link
Owner

This is most of the implementation for #146, except for chat messages because chat needs a mini-rework.

Implements:

  • background music
  • ambient map sounds (with distance-based volume control)
  • UI control sounds
  • weapon/spell sounds
  • quest sounds
  • Any other sounds except chat messages

ethanmoffat added 23 commits May 12, 2022 20:48
@ethanmoffat
Play background music using open source midi player. Respect music co…
bd5a5f7 
…ntrol in map properties for behavior of playing background music
@ethanmoffat
Remove background music related calls in old code
109a0cd
@ethanmoffat
Ambient sounds
f26b177
@ethanmoffat
Noises for effects
ab1b045
@ethanmoffat
Volume change on ambient sounds based on proximity to sound tiles
ba4c6df
@ethanmoffat
Play sound when attacking with a weapon
90670f8
@ethanmoffat
Add sound effects for some map interactions
e33bb5c
@ethanmoffat
Move ambient sound volume adjustment to DynamicMapObjectUpdater
9a01d7c
@ethanmoffat
Play 'dead' sound effect when main player dies
be078b2
@ethanmoffat
Fix percent health display when taking spikes damage
56eedfe
@ethanmoffat
Fill in some unknown sound effect ID values
9947552
@ethanmoffat
Add events for StatusBar open/close
110887c
@ethanmoffat
Update SfxPlayer to take ConfigurationProvider as a dependency. Coupl…
f195251 
…es configuration value check to playing of a given sound effect.
@ethanmoffat
Login, DeleteCharacter, and dialog sound effects
3ee5986
@ethanmoffat
Remove redundant checks for sound enabled. Call moved to SfxPlayer
db7a356
@ethanmoffat
Implement binding of sounds to controls for pre-game menus/dialogs
2bfc8a4
@ethanmoffat
More UI sounds. Includes panel interaction sounds and HUD buttons.
c76e4f2
@ethanmoffat
Swallow intermittent bugs due to race conditions from updating game c…
032df93 
…omponents collection
@ethanmoffat
Remove old audio related code
94bce00
@ethanmoffat
Add MUSIC_PLAYER handler for server-triggered playing of sfx
46f70a2
@ethanmoffat
Add sounds for dialogs. Fix sounds for quest PlaySound action and map…
f405ab8 
… evac. Signal sound effects when doing a buy/sell/craft/bank action.
@ethanmoffat
Remove todo comment from XnaControlSoundMapper (moving remaining TODO…
ba021e4 
… to github issue)
@ethanmoffat
Add paperdoll item sounds
eb4ecb8
@ethanmoffat ethanmoffat added this to the v0.10 - Up to Speed milestone May 24, 2022
@ethanmoffat ethanmoffat merged commit fcfd2cd into master May 24, 2022
@ethanmoffat ethanmoffat deleted the sound branch May 24, 2022 02:14
@MrDanOak MrDanOak mentioned this pull request Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10 - Up to Speed
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanmoffat