Add handlers and requests for MapInfo packets #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmoffat
reviewed
Mar 27, 2022
|
This PR addresses #154 |
Rename AutoRefresh2 to NPCMapInfo Rename Appear to MapInfo Change NPCEnterMapHandler to MapInfoHandler Make MapInfoHandler read character data
sorokya
force-pushed
the
mapinfo-packets
branch
from
e5c7fab to
db82164
Compare
Addressed feedback and I did some testing against EOSERV/ETHEOS. Had to adjust the MapInfo reply handler to work with them. Players and NPCs still appeared and behaved as expected. That should be the only possibly breaking change I think. The EOSERV already ignores the MapInfo requests packets so that should be safe. |
ethanmoffat
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old Appear_Reply packet handler with a new MapInfo_Reply handler.
All places where the client was skipping unknown Player IDs or NPC indexes will now store those unknowns in ICurrentMapStateRepository.
Once a second the client will send either a MapInfo_Request, CharacterMapInfo_Request, or NPCMapInfo_Request packet to the server to get the unknown data.
This still doesn't fix the issue of removing out of view characters/npcs from the map. I'm not exactly sure what triggers it in the official client but it seems like if something is on the very edge of the screen (12 tiles away) it will be dropped from view when the map re-renders.
I wasn't sure where the best place to implement this behavior was though. Up for suggestions if you have any. This of course can be handled in a separate PR.