Update session id logic

[sorokya]

This branch updates the Session ID logic around Account, Character, Welcome, and Warp packets to closer match the original GameServer and reoserv.

There's a big issue around PacketBuilder.AddShort not letting you add a ushort though!

[ethanmoffat]

What are the results of testing these changes against etheos/eoserv/GameServer? Normally I'd assume it works but I'd like you to confirm because of the changes to the InitReply enum and reading data around it.

You can use test.etheos.moffat.io:8078 for etheos, and moffat.io:8079 for gameserver

[sorokya]

What are the results of testing these changes against etheos/eoserv/GameServer? Normally I'd assume it works but I'd like you to confirm because of the changes to the InitReply enum and reading data around it.

You can use test.etheos.moffat.io:8078 for etheos, and moffat.io:8079 for gameserver

I’ll try it out with both :)

[sorokya]

What are the results of testing these changes against etheos/eoserv/GameServer? Normally I'd assume it works but I'd like you to confirm because of the changes to the InitReply enum and reading data around it.
You can use test.etheos.moffat.io:8078 for etheos, and moffat.io:8079 for gameserver

I’ll try it out with both :)

Tested with eoserv and everything worked fine
I tried your test.etheos.moffat.io for etheos but the client couldn't connect.
GameServer is bombing on account create. I'll try to debug it further later

[ethanmoffat]

What are the results of testing these changes against etheos/eoserv/GameServer? Normally I'd assume it works but I'd like you to confirm because of the changes to the InitReply enum and reading data around it.
You can use test.etheos.moffat.io:8078 for etheos, and moffat.io:8079 for gameserver

I’ll try it out with both :)

Tested with eoserv and everything worked fine I tried your test.etheos.moffat.io for etheos but the client couldn't connect. GameServer is bombing on account create. I'll try to debug it further later

Try etheos-test.westus3.azurecontainer.io:8078...apparently my pipeline isn't deleting old dns entries so I've got a bunch of stale IP addresses on the test.etheos.moffat.io A record 😬

[ethanmoffat]

For these lines, do this instead of creating an async lambda:

if (!await SafeGetFile(() => _fileRequestActions.GetMapFromServer(_currentMapStateProvider.CurrentMapID, sessionID)))
    return;

It reduces the overhead in the async state machine when you return the task directly, since it is eventually await anyway

[sorokya]

Done :)

[sorokya]

What are the results of testing these changes against etheos/eoserv/GameServer? Normally I'd assume it works but I'd like you to confirm because of the changes to the InitReply enum and reading data around it.
You can use test.etheos.moffat.io:8078 for etheos, and moffat.io:8079 for gameserver

I’ll try it out with both :)

Tested with eoserv and everything worked fine I tried your test.etheos.moffat.io for etheos but the client couldn't connect. GameServer is bombing on account create. I'll try to debug it further later

Try etheos-test.westus3.azurecontainer.io:8078...apparently my pipeline isn't deleting old dns entries so I've got a bunch of stale IP addresses on the test.etheos.moffat.io A record 😬

Re-tested with GameServer and etheos. Both work as intended :)