Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVP - Visuals #342

Closed
sjbmcg opened this issue Apr 17, 2024 · 2 comments · Fixed by #346
Closed

PVP - Visuals #342

sjbmcg opened this issue Apr 17, 2024 · 2 comments · Fixed by #346
Labels
feature good first issue If you're looking for something easy to work on this is a great starting issue!
Milestone
Version 1

Comments

@sjbmcg
Copy link
Contributor

sjbmcg commented Apr 17, 2024

Expected:
Untitled
Actual:
image
Replication:
Go to PK with the vanilla EO client and attack your character logged in on the Endless Client.
@ethanmoffat ethanmoffat added feature good first issue If you're looking for something easy to work on this is a great starting issue! labels Apr 21, 2024
@ethanmoffat ethanmoffat added this to the Version 1 milestone Apr 21, 2024
@ethanmoffat
Copy link
Owner

I guess PK attack was never implemented. Whoops.

Need to handle AVATAR_REPLY and check for any other potential missed packets.

@sjbmcg
Copy link
Contributor Author

sjbmcg commented Apr 23, 2024 •
edited
Loading

I've begun addressing this issue.

sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 23, 2024
@sjbmcg
Fix for ethanmoffat#342
66ec8a3 
- Implemented PVP visuals
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 24, 2024
@sjbmcg
ethanmoffat#342 Implement attack visuals in PvP maps
a5729de 
Added visuals for player attacks in PvP maps
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 24, 2024
@sjbmcg
ethanmoffat#342 Implement attack visuals in PvP maps
2720696 
Added visuals for player attacks in PvP maps
@ethanmoffat ethanmoffat linked a pull request Apr 24, 2024 that will close this issue
Implemented PVP Visuals for #342 #346
Merged
ethanmoffat added a commit that referenced this issue Apr 24, 2024
@sjbmcg @ethanmoffat
Implemented PVP Visuals for #342 (#346)
83b3fd4 
* Add AvatarReplyHandler.cs

* Minor fix: address crash in NPCTakeDamageHandler for unknown npc index

---------

Co-authored-by: Ethan Moffat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue If you're looking for something easy to work on this is a great starting issue!
Projects
None yet
Milestone
Version 1
Development

Successfully merging a pull request may close this issue.

Implemented PVP Visuals for #342 sjbmcg/EndlessClient
2 participants
@ethanmoffat @sjbmcg