Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing sound effect when giving "safety comment" for dropping a large amount of gold #319

Closed
ethanmoffat opened this issue May 25, 2023 · 2 comments · Fixed by #343
Closed

Missing sound effect when giving "safety comment" for dropping a large amount of gold #319

ethanmoffat opened this issue May 25, 2023 · 2 comments · Fixed by #343
Labels
bug good first issue If you're looking for something easy to work on this is a great starting issue!
Milestone
Version 1

Comments

@ethanmoffat
Copy link
Owner

In the vanilla client, the sound effect Login (also ServerMessage) plays when the dialog is shown
@ethanmoffat ethanmoffat added bug good first issue If you're looking for something easy to work on this is a great starting issue! labels May 25, 2023
@ethanmoffat ethanmoffat added this to the Version 1 milestone May 25, 2023
@sjbmcg
Copy link
Contributor

sjbmcg commented Apr 20, 2024

If I remember correctly, the sound effect is applied once along with the safety message.

sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 20, 2024
@sjbmcg
Resolved: Missing Sound Effect on Gold Drop Warning ethanmoffat#319
a1db30f 
Added "Login" sound effect to gold drop warning dialog.
Ensured single occurrence of warning message and sound, aligning with Vanilla EO.
@ethanmoffat
Copy link
Owner Author

You're correct, the dialog/sfx is only shown once

sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 20, 2024
@sjbmcg
Addressing ethanmoffat#319 PR
1eeea57
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 20, 2024
@sjbmcg
ethanmoffat#319
d429292 
changes
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 20, 2024
@sjbmcg
ethanmoffat#319
96cb547 
changes
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 20, 2024
@sjbmcg
ethanmoffat#319 - Sfx Issue now addressed after initial distraction f…
aa1d4a9 
…rom sister asking for git practise

- sfx upon opening
sjbmcg added a commit to sjbmcg/EndlessClient that referenced this issue Apr 22, 2024
@sjbmcg
Addressed PR feedback and resolved SFX issue ethanmoffat#319
7ba578f 
Fixed SFX issue mentioned in PR ethanmoffat#319 by incorporating changes as per Ethan's feedback.
@ethanmoffat ethanmoffat linked a pull request Apr 23, 2024 that will close this issue
Resolved: Missing Sound Effect on Gold Drop Warning #319 #343
Merged
ethanmoffat pushed a commit that referenced this issue Apr 23, 2024
@sjbmcg
Resolved: Missing Sound Effect on Gold Drop Warning #319 (#343)
7722bc2 
- Added "Login" sound effect to gold drop warning dialog.
- Ensured single occurrence of warning message and sound, aligning with Vanilla EO.
- Limit button click sound to only the "cancel" button of ItemTransferDialog, aligning with Vanilla EO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue If you're looking for something easy to work on this is a great starting issue!
Projects
None yet
Milestone
Version 1
Development

Successfully merging a pull request may close this issue.

Resolved: Missing Sound Effect on Gold Drop Warning #319 sjbmcg/EndlessClient
2 participants
@ethanmoffat @sjbmcg