Fix reversed condition when detecting change in map file RID

ethanmoffat · May 28, 2024 · 91e3c9b · 91e3c9b
1 parent 33b8431
commit 91e3c9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/EOLib.IO/Services/Serializers/MapPropertiesSerializer.cs b/EOLib.IO/Services/Serializers/MapPropertiesSerializer.cs
@@ -62,8 +62,8 @@ public IMapFileProperties DeserializeFromByteArray(byte[] data)
 
             var checksumArray = new List<int>
             {
-                NumberEncoder.DecodeNumber(new byte[] { data[3], data[4] }),
-                NumberEncoder.DecodeNumber(new byte[] { data[5], data[6] }),
+                _numberEncoderService.DecodeNumber(data[3], data[4]),
+                _numberEncoderService.DecodeNumber(data[5], data[6]),
             };
             var mapNameArray = data.Skip(7).Take(24).ToArray();
             var mapName = _mapStringEncoderService.DecodeMapString(mapNameArray);

diff --git a/EOLib/Net/FileTransfer/FileRequestActions.cs b/EOLib/Net/FileTransfer/FileRequestActions.cs
@@ -133,7 +133,7 @@ private bool NeedMap(int mapID, IReadOnlyList<int> expectedChecksum, int expecte
 
             var actualLength = _mapFileRepository.MapFiles[mapID].Properties.FileSize;
 
-            return expectedChecksum.SequenceEqual(_mapFileRepository.MapFiles[mapID].Properties.Checksum) ||
+            return !expectedChecksum.SequenceEqual(_mapFileRepository.MapFiles[mapID].Properties.Checksum) ||
                 expectedLength != actualLength;
         }