Use appropriate guild rank defaults. Prevents access to guild managem…

…ent menu items when joining a newly created guild.
ethanmoffat · Oct 27, 2024 · 0f2969d · 0f2969d
1 parent c8c6879
commit 0f2969d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/EOLib/Domain/Interact/Guild/GuildActions.cs b/EOLib/Domain/Interact/Guild/GuildActions.cs
@@ -130,7 +130,8 @@ public void LeaveGuild()
             _characterRepository.MainCharacter = _characterRepository.MainCharacter
                 .WithGuildTag("   ")
                 .WithGuildName(string.Empty)
-                .WithGuildRank(string.Empty);
+                .WithGuildRank(string.Empty)
+                .WithGuildRankID(0);
         }
 
         public void RequestToCreateGuild(string guildTag, string guildName, string guildDescription)

diff --git a/EOLib/PacketHandlers/Guild/GuildAgreeHandler.cs b/EOLib/PacketHandlers/Guild/GuildAgreeHandler.cs
@@ -35,7 +35,8 @@ public override bool HandlePacket(GuildAgreeServerPacket packet)
             _characterRepository.MainCharacter = _characterRepository.MainCharacter
                 .WithGuildTag(packet.GuildTag.ToUpper())
                 .WithGuildName(packet.GuildName.Capitalize())
-                .WithGuildRank(packet.RankName.Capitalize());
+                .WithGuildRank(packet.RankName.Capitalize())
+                .WithGuildRankID(9);
 
             foreach (var notifier in _guildNotifiers)
                 notifier.NotifyAcceptedIntoGuild();

diff --git a/EOLib/PacketHandlers/Guild/GuildKickHandler.cs b/EOLib/PacketHandlers/Guild/GuildKickHandler.cs
@@ -29,7 +29,8 @@ public override bool HandlePacket(GuildKickServerPacket packet)
             _characterRepository.MainCharacter = _characterRepository.MainCharacter
                 .WithGuildTag("   ")
                 .WithGuildName(string.Empty)
-                .WithGuildRank(string.Empty);
+                .WithGuildRank(string.Empty)
+                .WithGuildRankID(0);
             return true;
         }
     }