add timestamp to commit datasource
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmdavidson
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Hi @pgaubatz, thanks for the contribution! There's just one little piece missing for the tests.
| @@ -23,6 +23,7 @@ build { | |||
| "echo 'num_branches: ${length(data.git-commit.test.branches)}'", | |||
| "echo 'author: ${data.git-commit.test.author}'", | |||
| "echo 'committer: ${data.git-commit.test.committer}'", | |||
| "echo 'timestamp: ${data.git-commit.test.timestamp}'", | |||
There was a problem hiding this comment.
Can you please also add the timestamp line to the acceptance tests? You just need to create a regex to match the line with the timestamp, and then use it in the checkMatch function. See the commit message regex and commit message check as an example.
There was a problem hiding this comment.
thanks for the feedback. I just added the missing lines in 94574c9
ethanmdavidson
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small addition exposes the timestamp of a commit as an RFC3339 formatted string.