Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildcache docs for read-only cache #175

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Mar 21, 2024

The documentation states that

A build cache can be configured to be read-only by not providing a key in the cache configuration file.

However, not providing a key results in:

'key' is a required property

Failed validating 'required' in schema:
    {'$schema': 'http://json-schema.org/draft-07/schema#',
     'additionalProperties': False,
     'properties': {'key': {'default': None,
                            'oneOf': [{'type': 'string'},
                                      {'type': 'null'}]},
                    'root': {'type': 'string'}},
     'required': ['key', 'root'],
     'title': 'Schema for Spack Stack cache.yaml',
     'type': 'object'}

This PR removes key from the required keywords, since it has a default value null.

@RMeli RMeli requested a review from bcumming March 21, 2024 08:42
@RMeli RMeli marked this pull request as draft March 21, 2024 09:08
@RMeli
Copy link
Member Author

RMeli commented Mar 21, 2024

Actually, this fails later on with

==> Selected 23 specs to push to file:///bret/scratch/cscs/rmeli/spack-cache/user-environment
==> Error: No default key available for signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant