Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset file pointer before retrying to upload a file, after rate limit is reached #86

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Feb 21, 2024

When the rate limit is reached we need to reset the file pointer of the files before making the request, otherwise an empty file is uploaded to FirecREST. This bug affected the job submission and simple upload.

@ekouts ekouts self-assigned this Feb 21, 2024
@ekouts ekouts requested a review from jpdorsch February 21, 2024 12:45
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekouts ekouts merged commit 781430a into eth-cscs:main Feb 21, 2024
5 checks passed
@ekouts ekouts deleted the bugfix/post_retry_file branch February 21, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants