Adapt slurm checks to alps #253
Open
+116
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
requested changes
Jan 7, 2025
jgphpc
reviewed
Jan 8, 2025
| @@ -11,7 +11,7 @@ | |||
| class HaswellFmaCheck(rfm.CompileOnlyRegressionTest): | |||
| def __init__(self): | |||
| self.descr = 'check for avx2 instructions' | |||
| self.valid_systems = ['dom:login', 'daint:login'] | |||
| self.valid_systems = [] | |||
There was a problem hiding this comment.
1/ we no longer have haswell systems
2/ this test will fail on alps:
Failed to find the following module(s): "craype-haswell"
do you want to update it (using procinfo) or delete the test ? + it seems that the roadmap for cpe on alps is in CE
jgphpc
reviewed
Jan 8, 2025
| ]) | ||
|
|
||
| def __init__(self): | ||
| self.descr = f'LibSciAcc symlink check of {self.lib_name}' | ||
| self.valid_systems = [ | ||
| 'daint:login', 'daint:gpu', | ||
| 'dom:login', 'dom:gpu', | ||
| 'daint:login', 'daint:normal' |
jgphpc
reviewed
Jan 8, 2025
| @@ -11,8 +11,7 @@ class LibSciResolveBaseTest(rfm.CompileOnlyRegressionTest): | |||
| sourcesdir = 'src/libsci_resolve' | |||
| sourcepath = 'libsci_resolve.f90' | |||
| executable = 'libsciresolve.x' | |||
| valid_systems = ['daint:login', 'daint:gpu', 'dom:login', 'dom:gpu'] | |||
| modules = ['craype-haswell'] | |||
| valid_systems = ['daint:login', 'daint:normal'] | |||
| maintainers = ['AJ', 'LM'] | |||
jgphpc
reviewed
Jan 8, 2025
| @@ -23,7 +22,7 @@ def set_postbuild_cmds(self): | |||
|
|
|||
| @rfm.simple_test | |||
| class NvidiaResolveTest(LibSciResolveBaseTest): | |||
| accel_nvidia_version = parameter(['60']) | |||
| accel_nvidia_version = parameter(['90']) | |||
There was a problem hiding this comment.
maybe an opportunity to deactivate the mkl test (below) ?
There was a problem hiding this comment.
- line 41
You can't view this issue
looks like the issue is that you must load cray-libsci_acc too.
On alps, it fails with:
At least one of these module(s) must be loaded: nvhpc PrgEnv-nvhpc nvhpc-mixed atleast("cudatoolkit","12.0")
There was a problem hiding this comment.
regex needs an update:
0x0000000000000001 (NEEDED) Shared library: [libsci_cray.so.6]
0x0000000000000001 (NEEDED) Shared library: [libsci_gnu_123.so.6]
jgphpc
reviewed
Jan 8, 2025
| 'CRAY_XPMEM:CRAY_DMAPP:CRAY_PMI:CRAY_UGNI:' | ||
| 'CRAY_UDREG:CRAY_LIBSCI:CRAYPE:CRAY:' | ||
| 'PERFTOOLS:CRAYPAT'), | ||
| 'PE_PRODUCT_LIST': ('CRAYPE_ARM_GRACE:CRAYPE:PERFTOOLS:CRAYPAT'), | ||
| 'SCRATCH': r'/scratch/[\S+]', | ||
| 'XDG_RUNTIME_DIR': r'/run/user/[\d+]' | ||
| } |
There was a problem hiding this comment.
ssh will fail now on alps because of MFA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.