Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for ambiguous complex multiplication overloads in HIP in larft.cu #1241

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add workaround for ambiguous complex multiplication overloads in HIP in larft.cu #1241

merged 1 commit into from
Dec 18, 2024

Conversation

msimberg
Copy link
Collaborator

No description provided.

@msimberg msimberg self-assigned this Dec 16, 2024
@msimberg msimberg force-pushed the larft-hip-complex branch 3 times, most recently from dffffa4 to 5b6fe1d Compare December 16, 2024 16:28
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg mentioned this pull request Dec 17, 2024
Merged
@msimberg msimberg requested review from aurianer, rasolca, albestro and RMeli and removed request for rasolca and aurianer December 17, 2024 08:39
@msimberg msimberg marked this pull request as ready for review December 17, 2024 08:39
@msimberg
Copy link
Collaborator Author

This is not ready for merging since it depends on #1240 which needs some cleanup. It's ready for review though (the last commit is the only new change in this PR). This implements the most minimal workaround for the issue. On #1240 the ROCm 6.0.2 pipeline fails with the error reported in #1239 (https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/8655570191#L231). On this PR the pipeline passes. The ROCm 6.2.4 pipeline fails on both this and #1240, and I would suggest skipping it at least for the 0.7.1 patch release (#1240 (comment)).

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

RMeli
RMeli approved these changes Dec 18, 2024
View reviewed changes
src/lapack/gpu/larft.cu Show resolved Hide resolved
@msimberg
Copy link
Collaborator Author

With #1240 merged, this PR fixes the build error on the new CI configuration: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/8672697339.

@msimberg msimberg mentioned this pull request Dec 18, 2024
Merged
@rasolca rasolca merged commit 0bd434c into eth-cscs:master Dec 18, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@rasolca
Doc: Add workaround for ambiguous complex multiplication overloads in…
6cc593f 
… HIP in `larft.cu` (#1241)
@msimberg msimberg deleted the larft-hip-complex branch December 18, 2024 11:41
@msimberg msimberg added this to the v0.7.1 milestone Dec 18, 2024
msimberg added a commit that referenced this pull request Dec 18, 2024
@msimberg
Add workaround for ambiguous complex multiplication overloads in HIP …
dd4a4f6 
…in `larft.cu` (#1241)
@msimberg msimberg mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

@albestro albestro albestro approved these changes

@rasolca rasolca rasolca approved these changes

Assignees

@msimberg msimberg

Labels
None yet
Projects
DLA-F Planning
Archived in project
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@msimberg @rasolca @albestro @RMeli