Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation flags #1043

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix compilation flags #1043

merged 1 commit into from
Nov 20, 2023

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Nov 20, 2023

Use -pedantic instead of -pedantic-errors.

Note: in the CI with -Werror pedantic warnings are still reported as error.

@rasolca rasolca added Type:Bug Something isn't working Priority:Urgent labels Nov 20, 2023
@rasolca rasolca added this to the v0.3.1 milestone Nov 20, 2023
@rasolca
Copy link
Collaborator Author

rasolca commented Nov 20, 2023

cscs-ci run

@rasolca rasolca self-assigned this Nov 20, 2023
@rasolca rasolca mentioned this pull request Nov 20, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd4d57f) 93.97% compared to head (3598d08) 93.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1043   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files         145      145           
  Lines        8857     8857           
  Branches     1125     1125           
=======================================
  Hits         8323     8323           
  Misses        324      324           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rasolca rasolca merged commit 0275916 into master Nov 20, 2023
@rasolca rasolca deleted the rasolca/gcc9/fix1 branch November 20, 2023 15:22
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
@rasolca rasolca modified the milestones: v0.3.1, v.0.3.1 Nov 20, 2023
rasolca added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Urgent Type:Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants