Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make C API functions noexcept #1038

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Make C API functions noexcept #1038

merged 3 commits into from
Nov 21, 2023

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Nov 15, 2023

Adds a macro DLAF_NOEXCEPT_CPP (bikeshedding on the name welcome) which expands to noexcept in C++ mode and nothing in C mode. I've applied this to the C API function declarations in headers in dlaf.c_api. I've made the function definitions unconditionally noexcept since they're always built in C++ mode.

I have not touched the test wrappers since they are in .c files and built in C mode. I have also not done anything to the blacs declarations since they're just declarations.

@msimberg
Copy link
Collaborator Author

cscs-ci run

include/dlaf_c/utils.h Outdated Show resolved Hide resolved
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg requested a review from RMeli November 20, 2023 15:31
@msimberg msimberg added this to the Cleanup milestone Nov 20, 2023
@rasolca rasolca merged commit 40e4530 into eth-cscs:master Nov 21, 2023
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants