Support for dockerized RPC clients + Hostname resolution when attaching to RPC clients #972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I've extended the check that is determining if a RPC client is already running to also query the network connections in addition to the process list. The error I've observed on a
Ubuntu 18.04 LTS
was that only localhost RPC clients could be detected with the existing code. Even dockerized RPC clients bound to the127.0.0.1
could not be attached.How I did it
I've adapted the logic to first try the process list and then the network connections.
I've also implemented hostname resolution which becomes handy when the RPC client is bound to a specific hostname instead of IP which is often the case when used in docker-compose environments.
How to verify it
Then in another terminal
Checklist