Network host parameter is not respected when launching local development RPC network nodes

[danceratopz]

Environment information

• brownie Version: 1.18.2
• ganache-cli Version: 6.12.2
• solc Version: 0.8.11+commit.d7f03943.Linux.g++
• Python Version: 3.8.12
• OS: linux

What was wrong?

Brownie does not apply the host parameter configured using the "brownie networks" CLI when it launches a local RPC network node for use within a development console.

For example, if the local (ganache) development network is modified to use 0.0.0.0:

brownie networks modify development host="http://0.0.0.0"

brownie ignores the host configuration when it launches ganache (only the cmd_settings parameters are passed to ganache):

➜ brownie console --network development
Brownie v1.18.2 - Python development framework for Ethereum

xxx is the active project.

Launching 'ganache-cli --accounts 10 --hardfork istanbul --gasLimit 12000000 --port 8545 --defaultBalanceEther 100'...
Brownie environment is ready

This is required, for example, when connecting to a local network node from a client running within a docker container.

How can it be fixed?

There's an easy work-around: Start ganache manually and supply the required host via the -h flag; brownie will attach to this RPC instead of launching a new one.

A fix would require propagating the parameter to the code where the rpc is launched. Currently, it the host parameter appears to be ignored when starting local network nodes, unless I've missed something :)