Fix/miner downloader autopause #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er imports ok The BlockFetcher handles importing announced and broadcasted blocks, which are block notifications supposed by peers to be at or near the canonical head. If we successfully import a block by the fetcher channel, then, we can suppose ourselves to be synced, and therefore should not longer handle downloader sync attempts as eligible for pausing mining. This design assumes that the fetcher's parameters assure that we can only import relevant and valid head blocks locally; ie. -7<n<32 blocks from our local head, and having valid headers with existing parents, etc. Date: 2023-11-28 08:24:14-07:00 Signed-off-by: meows <[email protected]>
Date: 2023-11-28 08:39:49-07:00 Signed-off-by: meows <[email protected]>
This point in the code is important. Its where the txpool is permitted to accept txes, which is pending sync completion. The miner also cares about sync completion, which is why the fetcher fires the event here. This commit only moves the relevvant comment to a location which is hopefully harder to accidentally get removed in a merge. Date: 2023-11-29 16:24:04-07:00 Signed-off-by: meows <[email protected]>
The inserterFn type interface uses types.Blocks. We should not arbitrarily vary from this pattern. So use 'Chain' and types.Blocks instead of the singular block. Date: 2023-11-30 06:14:47-07:00 Signed-off-by: meows <[email protected]>
meowsbits
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read https://github.com/ethereum/devp2p/blob/master/caps/eth.md#block-propagation.
This patch infers "synced" status by the successful status of a
BlockFetcher-directed chain insertion.The
BlockFetchertype exclusively handles the (optional) fetching and (always) importing of block(s) received via the following wire protocol messages.If a block is successfully inserted into our local chain by these means, the miner infers that we are synced, and disables the autopause-for-downloader-events mechanism.
Resolves #586