Feat/audit bootnodes ci #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: 2021-03-01 14:37:11-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 14:44:50-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 14:51:13-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 14:55:00-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 15:07:31-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 15:09:33-06:00 Signed-off-by: meows <[email protected]>
Date: 2021-03-01 15:16:53-06:00 Signed-off-by: meows <[email protected]>
meowsbits
commented
Mar 1, 2021
ziogaschr
approved these changes
Mar 12, 2021
| enode_list="$(cat "$1" |grep -E 'enode://' | sed 's-"--g' | sed 's-\t--g'| sed 's/,.*//g')" | ||
| echo "$enode_list" | while read -r line; do | ||
| if >/dev/null 2>&1 ./build/bin/devp2p discv4 ping "${line}"; then | ||
| >&2 echo "PASS: ${line}" |
There was a problem hiding this comment.
Woow, nice use of redirection. I am not good at bash and I am learning new stuff by checking your code @meowsbits :)
Yea, that's what I was thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #321
Installs a Github Actions CI Workflow that audits the bootnodes listed as chain configuration defaults (for all chains).
It uses
./build/bin/devp2p discv4 ping, pinging each enode. Nodes that respond pass, nodes that fail to respond... well, they fail. You had one job....The workflow is configured to run
params/bootnodes*goworkflow_dispatch)For
schedule(cron) andworkflow_dispatchtriggers, the workflow will remove failing enodes and create a pull request with that change set.For
pull_requesttriggers, the action will not create a PR; it will just just fail and the light will turn red ❌.As for the actual outcome of auditing the bootnodes, a complementary PR is here: meowsbits#15.