node: add test for the discovery endpoint to validate OpenRPC compliance #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziogaschr
commented
Jan 12, 2021
ziogaschr
commented
Jan 12, 2021
meowsbits
reviewed
Jan 12, 2021
meowsbits
approved these changes
Jan 13, 2021
|
@meowsbits please have a review of this d0dae58 and let's merge it |
meowsbits
reviewed
Jan 13, 2021
…dpoint set on CI" This reverts commit d0dae58.
…with the latest published spec
meowsbits
reviewed
Jan 14, 2021
|
I will merge it. Can you please add this @meowsbits? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #15
I used https://github.com/xeipuuv/gojsonschema as I haven't found another similar package used already in geth.