Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: discovery to return correct link for methods' externalDocs #297

Closed
ziogaschr opened this issue Jan 13, 2021 · 1 comment · Fixed by #309
Closed

rpc: discovery to return correct link for methods' externalDocs #297

ziogaschr opened this issue Jan 13, 2021 · 1 comment · Fixed by #309

Comments

@ziogaschr
Copy link
Member

Calling the rpc_discover gives wrong links to our repo codebase.

System information

CoreGeth
Version: 1.11.21-unstable
Architecture: amd64
Protocol Versions: [65 64 63]
Go Version: go1.15.5
Operating System: darwin
GOPATH=/Users/ziogaschr/Sites/go
GOROOT=/usr/local/Cellar/go/1.15.5/libexec

Expected behaviour

To point at our repo etclabscore/core-geth

"externalDocs": {
        "description": "Github remote link",
        "url": "https://github.com/etclabscore/core-geth/blob/master/internal/ethapi/api.go#L2004"
      }

Actual behaviour

It points at Ethereum repo ethereum/go-ethereum

"externalDocs": {
        "description": "Github remote link",
        "url": "https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L2004"
      }
@meowsbits
Copy link
Contributor

Of note here is that github.com/etclabscore/core-geth is, for the purposes of go at least, declared as github.com/ethereum/go-ethereum (https://github.com/etclabscore/core-geth/blob/master/go.mod#L1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants